Fix Bigbank PDF Importer ignoring cent amounts #3891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bigbank uses Estonian number format in their account transactions statement, namley a comma for decimal separation. Therefore amounts need to be parsed with the correct language code, and de_CH would have ignored decimal places.
MonkeySon
changed the title
|
Hello @MonkeySon Rebase... merge... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bigbank uses the Estonian number format in their account statement transactions, namely a comma as decimal separator.
Before, numbers were parsed by the ExtractorUtils with the de_CH country code, which uses a dot as decimal separator. This has the effect that cent amount are ignored, but the test still passed since it did not include cent amounts.
This pull request: